Customize IPM load flags used by pull event handlers#975
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 49.00% 49.24% +0.24%
==========================================
Files 23 22 -1
Lines 3304 3300 -4
==========================================
+ Hits 1619 1625 +6
+ Misses 1685 1675 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
build output shows that unit tests pass. CI is still failing with unrelated xunit-viewer issue. |
| ) | ||
| } | ||
|
|
||
| /// Configures additional flags to be used with zpm "load" by Package Manager pull event handlers |
There was a problem hiding this comment.
How does this handle flags that look different, e.g. load -dev -DNoMapping=1 -extra-pip-flags "--timeout 30"?
Should also probably test that these get handled correctly.
There was a problem hiding this comment.
Good point. I don't want to implement full argument parsing here so I'm going to go with the simple solution of just having a string of flags that gets injected directly into the zpm shell command.
There was a problem hiding this comment.
@isc-dchui This is done, and ready for another round of review please
3 participants
Description
Resolves #974
You can now configure custom load flags to be used by the IPM event handlers. This is enough of a niche that for now I'm not adding this setting to the Configure() API or the Settings page.
Testing
Unit test class is an integration test of the PackageManagerReload event handler, covering the existing and new behavior.
Checklist
mainbranch rebased or merged.git-webui/srchave matching changes ingit-webui/release)